Skip to content

[ty] Reserve union element storage#24849

Merged
charliermarsh merged 1 commit into
mainfrom
charlie/reserve-union
Apr 26, 2026
Merged

[ty] Reserve union element storage#24849
charliermarsh merged 1 commit into
mainfrom
charlie/reserve-union

Conversation

@charliermarsh

@charliermarsh charliermarsh commented Apr 26, 2026

Copy link
Copy Markdown
Member

Summary

Pre-allocate the vector since we know the size upfront.

@astral-sh-bot astral-sh-bot Bot added the ty Multi-file analysis & type inference label Apr 26, 2026
@charliermarsh charliermarsh added the internal An internal refactor or improvement label Apr 26, 2026
@astral-sh-bot

astral-sh-bot Bot commented Apr 26, 2026

Copy link
Copy Markdown

Typing conformance results

No changes detected ✅

Current numbers
The percentage of diagnostics emitted that were expected errors held steady at 88.13%. The percentage of expected errors that received a diagnostic held steady at 83.58%. The number of fully passing files held steady at 81/134.

@astral-sh-bot

astral-sh-bot Bot commented Apr 26, 2026

Copy link
Copy Markdown

Memory usage report

Memory usage unchanged ✅

@astral-sh-bot

astral-sh-bot Bot commented Apr 26, 2026

Copy link
Copy Markdown

ecosystem-analyzer results

No diagnostic changes detected ✅

Flaky changes detected. This PR summary excludes flaky changes; see the HTML report for details.

Full report with detailed diff (timing results)

@charliermarsh charliermarsh marked this pull request as ready for review April 26, 2026 21:58
@charliermarsh charliermarsh merged commit c7c24b1 into main Apr 26, 2026
56 checks passed
@charliermarsh charliermarsh deleted the charlie/reserve-union branch April 26, 2026 21:58
carljm added a commit that referenced this pull request Apr 27, 2026
* main: (44 commits)
  Update cargo-bins/cargo-binstall action to v1.18.1 (#24855)
  Update dependency ruff to v0.15.12 (#24857)
  Update taiki-e/install-action action to v2.75.18 (#24864)
  [ty] Model bool-op branch snapshots (#24458)
  [ty] Support `Unpack[TypedDict]` in `**kwargs` signatures (#24653)
  Update prek dependencies (#24858)
  Update Rust crate bitflags to v2.11.1 (#24859)
  Update Rust crate clap to v4.6.1 (#24860)
  Update Rust crate mimalloc to v0.1.49 (#24862)
  Update Rust crate uuid to v1.23.1 (#24863)
  Update Rust crate rayon to v1.12.0 (#24866)
  Update Rust crate libc to v0.2.185 (#24861)
  [ty] Reserve union element storage (#24849)
  [ty] bump conformance suite commit (#24848)
  [ty] Pass unmapped type variables to `SpecializationBuilder::build_with` (#24809)
  [ty] Avoid bookkeeping for unannotated functions (#24842)
  [ty] Optimize signature checking based on number of arguments (#24674)
  [ty] Avoid eagerly inferring legacy generic context (#24841)
  [ty] Skip decorator inference for undecorated functions (#24839)
  [ty] solve unions against generic protocols (#24837)
  ...
thejchap pushed a commit to thejchap/ruff that referenced this pull request May 23, 2026
## Summary

Pre-allocate the vector since we know the size upfront.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal An internal refactor or improvement ty Multi-file analysis & type inference

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants