[ty] Reject unsupported environment.python-version values in configuration files#24402
Merged
charliermarsh merged 1 commit intomainfrom Apr 5, 2026
Merged
[ty] Reject unsupported environment.python-version values in configuration files#24402charliermarsh merged 1 commit intomainfrom
environment.python-version values in configuration files#24402charliermarsh merged 1 commit intomainfrom
Conversation
6934d51 to
6980a4b
Compare
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 87.72%. The percentage of expected errors that received a diagnostic held steady at 82.85%. The number of fully passing files held steady at 74/132. |
Memory usage reportMemory usage unchanged ✅ |
|
| Lint rule | Added | Removed | Changed |
|---|---|---|---|
invalid-await |
0 | 40 | 0 |
invalid-return-type |
0 | 1 | 0 |
| Total | 0 | 41 | 0 |
Changes in flaky projects detected. Raw diff output excludes flaky projects; see the HTML report for details.
04af746 to
9249632
Compare
carljm
approved these changes
Apr 4, 2026
9249632 to
0c4c6a2
Compare
This was referenced Apr 7, 2026
charliermarsh
added a commit
that referenced
this pull request
Apr 10, 2026
## Summary Like #24402, we want to ignore unsupported Python versions that come from the editor. Instead, we'll fall back to the default version (if there's no other configuration set). One nuance here is that we don't actively show the user a popup if we ignore this version; we just use `tracing::warn!("{message}")`. It seems undesirable to show a popup at the conversion site, since we'd then be showing it even if the fallback version were never used. Is it desirable to show a popup _ever_?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
If a user specifies an unsupported value in
environment.python-version, we need to reject it, like we do on the CLI.