Skip to content

[ty] Move snapshot for code action test with trailing whitespace to external file#24359

Merged
MichaReiser merged 1 commit intomainfrom
micha/code-action-trailing-whitespace
Apr 2, 2026
Merged

[ty] Move snapshot for code action test with trailing whitespace to external file#24359
MichaReiser merged 1 commit intomainfrom
micha/code-action-trailing-whitespace

Conversation

@MichaReiser
Copy link
Copy Markdown
Member

Summary

Some editors (e.g. Zed) trim trailing whitespace, even if inside a string literal
and this test always started failing for me after making changes to the code_action.rs.

This PR moves this one snappshot to an external snapshot to prevent this from happening.

Test Plan

cargo test

@MichaReiser MichaReiser added internal An internal refactor or improvement ty Multi-file analysis & type inference labels Apr 2, 2026
@MichaReiser MichaReiser requested a review from carljm as a code owner April 2, 2026 09:51
@MichaReiser MichaReiser added the internal An internal refactor or improvement label Apr 2, 2026
@MichaReiser MichaReiser added the ty Multi-file analysis & type inference label Apr 2, 2026
@astral-sh-bot astral-sh-bot bot requested a review from dhruvmanila April 2, 2026 09:51
@MichaReiser MichaReiser enabled auto-merge (squash) April 2, 2026 09:51
@MichaReiser MichaReiser merged commit ef5c149 into main Apr 2, 2026
47 checks passed
@MichaReiser MichaReiser deleted the micha/code-action-trailing-whitespace branch April 2, 2026 09:56
carljm added a commit that referenced this pull request Apr 2, 2026
* main:
  Add a "release-gate" step to the release workflow (#24365)
  Disallow starred expressions as values of starred expressions (#24280)
  [`pyupgrade`] Ignore strings with string-only escapes (`UP012`) (#16058)
  [ty] Improve consistency and quality of diagnostics relating to invalid type forms (#24325)
  [flake8-type-checking] Clarify import cycle wording for TC001/TC002/TC003 (#24322)
  [`flake8-errmsg`] Avoid shadowing existing `msg` in fix for `EM101` (#24363)
  `RUF072`: skip formfeeds on dedent (#24308)
  Replace unmaintained `unic-ucd-category` crate with `icu_properties` (#24344)
  [ty] Replace markdown hard line breaks in snapshot tests (#24361)
  [ty] Move snapshot for code action test with trailing whitespace to external file (#24359)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal An internal refactor or improvement ty Multi-file analysis & type inference

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants