Skip to content

Store definition indexes as u32#24307

Merged
charliermarsh merged 1 commit intomainfrom
charlie/mem-2
Mar 30, 2026
Merged

Store definition indexes as u32#24307
charliermarsh merged 1 commit intomainfrom
charlie/mem-2

Conversation

@charliermarsh
Copy link
Copy Markdown
Member

@charliermarsh charliermarsh commented Mar 30, 2026

Summary

This change reduces the alignment of DefinitionKind from 8 to 4, which drops the entire size from 32 to 28 :)

@astral-sh-bot astral-sh-bot bot added the ty Multi-file analysis & type inference label Mar 30, 2026
@astral-sh-bot
Copy link
Copy Markdown

astral-sh-bot bot commented Mar 30, 2026

Typing conformance results

No changes detected ✅

Current numbers
The percentage of diagnostics emitted that were expected errors held steady at 86.61%. The percentage of expected errors that received a diagnostic held steady at 81.56%. The number of fully passing files held steady at 70/132.

@astral-sh-bot
Copy link
Copy Markdown

astral-sh-bot bot commented Mar 30, 2026

Memory usage report

Summary

Project Old New Diff Outcome
flake8 48.07MB 47.90MB -0.37% (183.74kB) ⬇️
trio 117.99MB 117.63MB -0.31% (371.49kB) ⬇️
sphinx 265.21MB 264.47MB -0.28% (757.01kB) ⬇️
prefect 716.74MB 714.86MB -0.26% (1.88MB) ⬇️

Significant changes

Click to expand detailed breakdown

flake8

Name Old New Diff Outcome
Definition 2.15MB 1.97MB -8.33% (183.74kB) ⬇️

trio

Name Old New Diff Outcome
Definition 4.35MB 3.99MB -8.33% (371.49kB) ⬇️

sphinx

Name Old New Diff Outcome
Definition 8.87MB 8.13MB -8.33% (757.01kB) ⬇️

prefect

Name Old New Diff Outcome
Definition 22.57MB 20.69MB -8.33% (1.88MB) ⬇️

@astral-sh-bot
Copy link
Copy Markdown

astral-sh-bot bot commented Mar 30, 2026

ecosystem-analyzer results

Lint rule Added Removed Changed
invalid-await 0 40 0
invalid-return-type 0 1 0
Total 0 41 0

Changes in flaky projects detected. Raw diff output excludes flaky projects; see the HTML report for details.

Full report with detailed diff (timing results)

@charliermarsh charliermarsh changed the base branch from charlie/mem-i to main March 30, 2026 16:02
@charliermarsh charliermarsh marked this pull request as ready for review March 30, 2026 17:04
@carljm carljm removed their request for review March 30, 2026 17:06
@AlexWaygood AlexWaygood requested review from MichaReiser and removed request for AlexWaygood March 30, 2026 17:09
Copy link
Copy Markdown
Member

@ibraheemdev ibraheemdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me.

@charliermarsh charliermarsh merged commit 4338fb7 into main Mar 30, 2026
51 checks passed
@charliermarsh charliermarsh deleted the charlie/mem-2 branch March 30, 2026 21:54
carljm added a commit that referenced this pull request Mar 31, 2026
* main: (35 commits)
  Store definition indexes as u32 (#24307)
  Avoid re-using symbol in RUF024 fix (#24316)
  [ty] Add materialization to `Divergent` type (#24255)
  [ty] Make `Divergent` a top-level type variant (#24252)
  [ty] Fix nested global and nonlocal lookups through forwarding scopes (#24279)
  Fetch the cargo-dist binary directly instead of using the installer (#24258)
  [ty] Fix panic on `list[Annotated[()]]` (#24303)
  Don't measure the AST deallocation time in parser benchmarks (#24301)
  Enable CodSpeed's memory benchmarks for simulation benchmarks (#24298)
  Upgrade imara-diff to 0.2.0 (#24299)
  [ty] Represent `InitVar` as a special form internally, not a class (#24248)
  `RUF067`: Allow dunder-named assignments in non-strict mode
  [`pyupgrade`] UP018 should detect more unnecessarily wrapped literals (UP018) (#24093)
  [ty] Remove unused `system.glob` method (#24300)
  [ty] Reject functional TypedDict with mismatched name (#24295)
  Update Rust crate arc-swap to v1.9.0 (#24292)
  [ty] Remove unused `@Todo(Functional TypedDicts)` (#24297)
  Update CodSpeedHQ/action action to v4.12.1 (#24290)
  Update taiki-e/install-action action to v2.69.6 (#24293)
  Update Rust crate toml to v1.0.7 (#24289)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ty Multi-file analysis & type inference

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants