[ty] Show truthiness in ConstraintSet display and simplify falsy error message#23913
Merged
AlexWaygood merged 1 commit intomainfrom Mar 12, 2026
Merged
[ty] Show truthiness in ConstraintSet display and simplify falsy error message#23913AlexWaygood merged 1 commit intomainfrom
AlexWaygood merged 1 commit intomainfrom
Conversation
…r message Display ConstraintSet with its satisfaction status: - `ConstraintSet[Literal[True]]` when always satisfied - `ConstraintSet[Literal[False]]` when never satisfied - `ConstraintSet[bool]` when ambiguous Also shorten "is statically known to be falsy" to "is always falsy" in static_assert error messages. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 85.29%. The percentage of expected errors that received a diagnostic held steady at 78.13%. The number of fully passing files held steady at 64/132. |
|
Memory usage reportMemory usage unchanged ✅ |
carljm
approved these changes
Mar 12, 2026
carljm
added a commit
that referenced
this pull request
Mar 13, 2026
* main: (94 commits) Fix shell injection via `shell=True` in subprocess calls (#23894) [ty] Refactor `relation.rs` to store state on a struct rather than passing around 7 arguments every time we recurse (#23837) Don't return code actions for non-Python documents (#23905) [ty] Make the default database truly statically infallible (#23929) [ty] Add `Download` button to ty playground which creates a zip export (#23478) [ty] Respect `kw_only` overwrites in dataclasses (#23930) [ty] Clarify in diagnostics that `from __future__ import annotations` only stringifies type annotations (#23928) [ty] Add a `Copy Markdown` button to playground (#23002) [ty] Fix folding range classification of lines starting with `#` (#23831) [ty] Fix folding ranges for notebooks (#23830) [ty] fix too-many-cycle panics when inferring literal type loop variables (#23875) Add `RegularCallableTypeOf` and `into_regular_callable` in `ty_extensions` (#23909) [ty] treat properties as full structural types (#23925) [ty] Avoid duplicated work during multi-inference (#23923) [ty]: make `possibly-missing-attribute` ignored by default [ty]: split out `possibly-missing-submodule` from `possibly-missing-attribute` Update astral-sh/setup-uv action to v7.5.0 (#23922) [ty] Show truthiness in ConstraintSet display and simplify falsy error message (#23913) Bump 0.15.6 (#23919) [ty] Narrow type context during collection literal inference (#23844) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A small quality-of-life improvement for playground debugging.
I always find it annoying when I do
reveal_type(is_subtype_of(bool, int))or similar and ty just tells me it's aConstraintSet😆 I have to doreveal_type(bool(is_subtype_of(bool, int)))to get the information I actually wanted out of ty. Now, we'll tell you whether the constraint set is known to be always, never or sometimes satisfied as part of the display of that constraint set:I also shortened the error message for
static_assert.Test Plan
mdtests updated