fix renovate actions/*-artifact updates#23675
Merged
AlexWaygood merged 1 commit intomainfrom Mar 2, 2026
Merged
Conversation
carljm
added a commit
that referenced
this pull request
Mar 2, 2026
* main: (30 commits) [ty] Introduce `types::bool`, `types::context_manager` and `types::iteration` (#23681) [ty] Move `KnownInstanceType`, and related types, to a new `known_instance.rs` submodule (#23680) [ty] Add `invalid-enum-member-annotation` lint rule (#23648) [`ruff`] Fix false positive for `re.split` with empty string pattern (`RUF055`) (#23634) [ty] Move `UnionType` and `IntersectionType` to a new `types::set_theoretic` submodule (#23678) [ty] Add unbound type variable detection in annotations (#23641) [ty] Remove `specialize_constrained` from constraint set module (#23677) [ty] Add partial support and validation for `Unpack` when used with tuple types (#23651) Update prek dependencies (#23661) [ty] make `StaticClassLiteral::explicit_bases` converge better in cycles (#23601) Improvements to CLAUDE.md (#23633) [ty] Move subscript logic out of `builder.rs` (#23653) Update Artifact GitHub Actions dependencies (#23676) Update actions/attest-build-provenance to 4.1.0 (#23654) Update Rust crate clearscreen to v4.0.5 (#23664) fix renovate `actions/*-artifact` updates (#23675) Update Rust crate clap to v4.5.60 (#23663) Update Rust crate unicode-ident to v1.0.24 (#23668) Update Rust crate anyhow to v1.0.102 (#23662) Update Rust crate pyproject-toml to v0.13.7 (#23666) ...
AlexWaygood
added a commit
to astral-sh/ty
that referenced
this pull request
Mar 4, 2026
The same as astral-sh/ruff#23675: > The intention here is that this should be a regex match. But that evidently is not working (astral-sh/ruff#23656 and astral-sh/ruff#23655 were filed as separate PRs rather than one combined PR). Looking at the renovate docs, it's possible that we need to surround the string with `/` in order for it to be considered a regular expression -- i.e., `/actions/.*-artifact/` rather than `actions/.*-artifact`. But a regex here also just feels like it's overcomplicating things anyway -- the only ones we aare about are `upload-artifact` and `download-artifact`! The same problem evidently exists on this repo too: see #2933 and #2934
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The intention here is that this should be a regex match. But that evidently is not working (#23656 and #23655 were filed as separate PRs rather than one combined PR). Looking at the renovate docs, it's possible that we need to surround the string with
/in order for it to be considered a regular expression -- i.e.,/actions/.*-artifact/rather thanactions/.*-artifact. But a regex here also just feels like it's overcomplicating things anyway -- the only ones we aare about areupload-artifactanddownload-artifact!Test Plan
npx --yes --package renovate -- renovate-config-validator. This eventually passed after I figured out how to upgrade the ancient version of renovate I had installed locally. (IDK how to use npm 😆)