[ty] More type-variable default validation#23639
Merged
AlexWaygood merged 3 commits intomainfrom Mar 5, 2026
Merged
Conversation
Typing conformance resultsNo changes detected ✅ |
|
Memory usage reportMemory usage unchanged ✅ |
Member
Author
|
Following #23623, I guess we now pass all the conformance tests regarding typevar default scoping. But I still think this PR improves semantics -- it matches pyright's behaviour. The upstream tests seem like they're missing some coverage. |
|
af5547b to
c1a2615
Compare
8e099a8 to
2920f62
Compare
oconnor663
approved these changes
Mar 3, 2026
Contributor
oconnor663
left a comment
There was a problem hiding this comment.
Meant to put the green checkmark on the last comment.
2920f62 to
6408c53
Compare
AlexWaygood
commented
Mar 5, 2026
Member
Author
There was a problem hiding this comment.
I know, I know... 400+ lines being added to infer/builder.rs... I'll rip it out into a submodule as a followup.
carljm
added a commit
that referenced
this pull request
Mar 5, 2026
* main: Update conformance suite commit hash (#23746) conformance.py: Collapse the summary paragraph when nothing changed (#23745) [ty] Make inferred specializations line up with source types more better (#23715) Bump 0.15.5 (#23743) [ty] Render all changed diagnostics in conformance.py (#23613) [ty] Split deferred checks out of `types/infer/builder.rs` (#23740) Discover markdown files by default in preview mode (#23434) [ty] Use `HasOptionalDefinition` for `except` handlers (#23739) [ty] Fix precedence of `all` selector in TOML configurations (#23723) [ty] Make `all` selector case sensitive (#23713) [ty] Add a diagnostic if a `TypeVar` is used to specialize a `ParamSpec`, or vice versa (#23738) [ty] Override home directory in ty tests (#23724) [ty] More type-variable default validation (#23639) [ty] Validate bare ParamSpec usage in type annotations, and support stringified ParamSpecs as the first argument to `Callable` (#23625) [ty] Add `all` selector to ty.json's `schema` (#23721) [ty] Add quotes to related issues links (#23720) [ty] Fix panic on incomplete except handlers (#23708)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We have several checks at the moment which fire on legacy type variables with invalid defaults in a class context, but which fail to check for legacy type variables with invalid defaults in a function context. This PR adds those missing checks.
The typing spec states that both legacy and PEP-695 type variables are not allowed to have defaults that:
The typing spec also states that a type variable with a default is not allowed to come before any type variables without defaults.
Test Plan
mdtests and snapshots