[pyflakes] Fix false positive for names shadowing re-exports (F811)#23356
Merged
ntBre merged 2 commits intoastral-sh:mainfrom Feb 27, 2026
Merged
[pyflakes] Fix false positive for names shadowing re-exports (F811)#23356ntBre merged 2 commits intoastral-sh:mainfrom
pyflakes] Fix false positive for names shadowing re-exports (F811)#23356ntBre merged 2 commits intoastral-sh:mainfrom
Conversation
… re-exports Fixes astral-sh#10874. In stub files, explicit re-exports (\`from x import y as y\`) at module scope were falsely flagged as redefined by class-scoped attributes with the same name. A class attribute binding in a nested scope should not invalidate a module-level re-export. Skip the F811 diagnostic when the shadowed binding is an explicit re-export.
ntBre
requested changes
Feb 16, 2026
Contributor
ntBre
left a comment
There was a problem hiding this comment.
Can you add a regression test for this showing that the issue is now resolved?
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| RUF100 | 11 | 11 | 0 | 0 | 0 |
Linter (preview)
ℹ️ ecosystem check detected linter changes. (+11 -0 violations, +0 -0 fixes in 1 projects; 55 projects unchanged)
python/typeshed (+11 -0 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --no-fix --output-format concise --preview --select E,F,FA,I,PYI,RUF,UP,W
+ stdlib/_socket.pyi:744:45: RUF100 [*] Unused `noqa` directive (unused: `F811`) + stdlib/_socket.pyi:841:63: RUF100 [*] Unused `noqa` directive (unused: `F811`) + stubs/psutil/psutil/_pswindows.pyi:49:84: RUF100 [*] Unused `noqa` directive (unused: `F811`) + stubs/psutil/psutil/_pswindows.pyi:50:84: RUF100 [*] Unused `noqa` directive (unused: `F811`) + stubs/psutil/psutil/_pswindows.pyi:51:68: RUF100 [*] Unused `noqa` directive (unused: `F811`) + stubs/psutil/psutil/_pswindows.pyi:52:68: RUF100 [*] Unused `noqa` directive (unused: `F811`) + stubs/psutil/psutil/_pswindows.pyi:53:72: RUF100 [*] Unused `noqa` directive (unused: `F811`) + stubs/psutil/psutil/_pswindows.pyi:54:76: RUF100 [*] Unused `noqa` directive (unused: `F811`) + stubs/pysftp/pysftp/__init__.pyi:105:20: RUF100 [*] Unused `noqa` directive (unused: `F811`) + stubs/pysftp/pysftp/__init__.pyi:79:89: RUF100 [*] Unused `noqa` directive (unused: `F811`) + stubs/pywin32/win32/win32ras.pyi:17:43: RUF100 [*] Unused `noqa` directive (unused: `F811`)
Changes by rule (1 rules affected)
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| RUF100 | 11 | 11 | 0 | 0 | 0 |
Contributor
Author
|
Added the regression test (F811_33.pyi) — verifies that module-level re-exports are not flagged as redefined by class-scoped attributes. CI should be green. Ready for another look when you have a moment. |
Contributor
Author
|
Gentle ping — added the regression test (F811_33.pyi) as requested. Ready for another look when you get a chance. |
ntBre
approved these changes
Feb 27, 2026
Contributor
ntBre
left a comment
There was a problem hiding this comment.
Thanks, this makes sense to me and seems to clean up a bunch of noqa comments in typeshed!
pyflakes] Fix false positive for names shadowing module-level re-exports (F811)
Contributor
|
Note that I dropped def foo():
import bar as bar
class C:
bar = 1 |
pyflakes] Fix false positive for names shadowing module-level re-exports (F811)pyflakes] Fix false positive for names shadowing re-exports (F811)
carljm
added a commit
that referenced
this pull request
Feb 27, 2026
* main: [ty] Take myself out of the reviewer pool for the next few days (#23618) [ty] Fix bug where ty would think that a `Callable` with a variadic positional parameter could be a subtype of a `Callable` with a positional-or-keyword parameter (#23610) [`ruff`] Add fix for `none-not-at-end-of-union` (`RUF036`) (#22829) Bump cargo dist to 0.31 (#23614) [`pyflakes`] Fix false positive for names shadowing re-exports (`F811`) (#23356) [`fastapi`] Handle callable class dependencies with `__call__` method (`FAST003`) (#23553) [ty] Recurse into tuples and nested tuples when applying special-cased validation of `isinstance()` and `issubclass()` (#23607) Update typing conformance suite commit (#23606) [ty] Detect invalid uses of `@final` on non-methods (#23604) [ty] Move the type hierarchy request handlers to individual modules [ty] Wire up the type hierarchy implementation with the LSP [ty] Add routine for mapping from system path to vendored path [ty] Implement internal routines for providing the LSP "type hierarchy" feature [ty] Add some helper methods on `ClassLiteral` [ty] Move some module name helper routines to methods on `ModuleName` [ty] Bump version of `lsp-types` [ty] Refactor to support building constraint sets differently (#23600) [ty] Dataclass transform: neither frozen nor non-frozen (#23366) [ty] Add snapshot tests for advanced `invalid-assignment` scenarios (#23581) [ty] disallow negative narrowing on SubclassOf types (#23598)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #10874.
In stub files, explicit re-exports (
from x import y as y) at module scope were falsely flagged as redefined (F811) by class-scoped attributes with the same name. A class attribute binding in a nested scope should not invalidate a module-level re-export.Skip the F811 diagnostic when the shadowed binding is an explicit re-export (
is_explicit_export()).Test plan
ruff check --select F811 stub.pyino longer emits false positivecargo test -p ruff_linter -- pyflakes— all 462 tests pass