[ty] Avoid narrowing on non-generic calls#22102
Merged
Merged
Conversation
Diagnostic diff on typing conformance testsNo changes detected when running ty on typing conformance tests ✅ |
|
CodSpeed Performance ReportMerging #22102 will improve performance by ×9.7Comparing Summary
Benchmarks breakdown
Footnotes
|
zanieb
approved these changes
Dec 20, 2025
carljm
reviewed
Dec 20, 2025
Comment on lines
+7021
to
+7022
| // We only need to attempt narrowing on generic calls, otherwise the type | ||
| // context has no effect. |
Contributor
There was a problem hiding this comment.
Hmm is this true? Doesn't e.g. a type context of a TypedDict affect inference of a dict literal, even for non-generic calls?
Contributor
There was a problem hiding this comment.
Oh but I guess in those cases we don't support a union type context
Member
Author
There was a problem hiding this comment.
A dictionary literal argument? If the call is non-generic, the only relevant type-context there is the annotated parameter type, which does not contain any type variables.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves astral-sh/ty#2026.