[ruff] Use helper function for empty f-string detection in in-empty-collection (RUF060)
#20249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
dylwil3
requested changes
Sep 4, 2025
Collaborator
dylwil3
left a comment
There was a problem hiding this comment.
Can you move these new examples to the end of the file and put a link to the relevant GitHub issue in a comment above them?
RUF060] Use helper function for empty f-string detectionruff] Use helper function for empty f-string detection in in-empty-collection (RUF060)
second-ed
pushed a commit
to second-ed/ruff
that referenced
this pull request
Sep 9, 2025
…y-collection` (`RUF060`) (astral-sh#20249) ## Summary Fixes astral-sh#20238 Replace inline f-string emptiness check with `is_empty_f_string` helper function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #20238
Replace inline f-string emptiness check with
is_empty_f_stringhelper functionTest Plan
I have added test cases to
crates/ruff_linter/resources/test/fixtures/ruff/RUF060.py