[flake8-async] Implement blocking-input rule (ASYNC250)#20122
Merged
amyreese merged 2 commits intoastral-sh:mainfrom Aug 28, 2025
Merged
[flake8-async] Implement blocking-input rule (ASYNC250)#20122amyreese merged 2 commits intoastral-sh:mainfrom
flake8-async] Implement blocking-input rule (ASYNC250)#20122amyreese merged 2 commits intoastral-sh:mainfrom
Conversation
Contributor
|
ntBre
reviewed
Aug 28, 2025
Contributor
ntBre
left a comment
There was a problem hiding this comment.
Looks great, thanks! Just a couple of minor things
crates/ruff_linter/src/rules/flake8_async/rules/blocking_input.rs
Outdated
Show resolved
Hide resolved
crates/ruff_linter/src/rules/flake8_async/rules/blocking_input.rs
Outdated
Show resolved
Hide resolved
Member
Author
|
@ntBre fixed the oversights and updated to use |
second-ed
pushed a commit
to second-ed/ruff
that referenced
this pull request
Sep 9, 2025
…-sh#20122) ## Summary Adds new rule to catch use of builtins `input()` in async functions. Issue astral-sh#8451 ## Test Plan New snapshosts in `ASYNC250.py` with `cargo insta test`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds new rule to catch use of builtins
input()in async functions.Issue #8451
Test Plan
New snapshosts in
ASYNC250.pywithcargo insta test.