Skip to content

[isort] Handle multiple continuation lines after module docstring (I002) #19818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ntBre merged 5 commits into from
Aug 15, 2025
Merged

[isort] Handle multiple continuation lines after module docstring (I002) #19818

ntBre merged 5 commits into from
Aug 15, 2025

Conversation

@danparizher
Copy link
Contributor

@danparizher danparizher commented Aug 8, 2025

Summary

Fixes #19815

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2025 •
edited
Loading

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@ntBre ntBre self-requested a review August 8, 2025 20:07
@ntBre ntBre added bug Something isn't working fixes Related to suggested fixes for violations labels Aug 14, 2025
ntBre
ntBre reviewed Aug 14, 2025
View reviewed changes
Copy link
Contributor

@ntBre ntBre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks right to me. I think a snapshot test would be helpful like in the last PR, though.

@danparizher danparizher requested a review from ntBre August 15, 2025 20:26
ntBre
ntBre approved these changes Aug 15, 2025
View reviewed changes
Copy link
Contributor

@ntBre ntBre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ntBre ntBre changed the title [isort] Fix I002: handle multiple continuation backslashes after module docstring in start_of_file to avoid syntax errors [isort] Handle multiple continuation lines after module docstring (I002) Aug 15, 2025
@ntBre ntBre merged commit f0e9c1d into astral-sh:main Aug 15, 2025
35 checks passed
@danparizher danparizher deleted the fix-19815 branch August 15, 2025 21:41
dcreager added a commit that referenced this pull request Aug 16, 2025
@dcreager
Merge branch 'main' into dcreager/inferrable
e34c8c9 
* main:
  [`isort`] Handle multiple continuation lines after module docstring (`I002`) (#19818)
  [`flake8-simplify`] Implement fix for `maxsplit` without separator (`SIM905`) (#19851)
  [`pycodestyle`] Make `E731` fix unsafe instead of display-only for class assignments (#19700)
@BrewTestBot BrewTestBot mentioned this pull request Aug 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ntBre ntBre ntBre approved these changes

Assignees

No one assigned

Labels

bug Something isn't working fixes Related to suggested fixes for violations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

start_of_file handles at most one backslash, making I002 introduce a syntax error

2 participants

@danparizher @ntBre