[ty] Fix bug #879 in signature help #19542
Conversation
|
|
|
||
| if offset >= call_expr.end() { | ||
| return None; | ||
| } |
There was a problem hiding this comment.
Given the doc comment on get_call_expr, it seems like a violation of its contract (aka a bug) for it to return a call expression that ends before offset. So wouldn't it be slighly better to handle this inside get_call_expr?
There was a problem hiding this comment.
Yes, you're correct. This fix wasn't sound. I've introduced a better fix — along with some tests to cover this case — in a new PR. The problem is that the old code was using a zero-length range when calling covering_node, and this returned the node to the left of the cursor position.
|
I don't think this is an issue but just wanted to point it out. Wouldn't this lead to signature help disappearing for nested calls? For example, in the Screen.Recording.2025-07-25.at.09.47.57.mov |
This PR fixes bug [#879](astral-sh/ty#879) where the signature help popup remains visible after typing the closing paren in a call expression. Co-authored-by: UnboundVariable <unbound@gmail.com>
|
@dhruvmanila, yes, you're correct. This fix wasn't sound. I've introduced a better fix — along with some tests to cover this case — in a new PR. |
This PR improves the "signature help" language server feature in two ways: 1. It adds support for the recently-introduced "stub mapper" which maps symbol declarations within stubs to their implementation counterparts. This allows the signature help to display docstrings from the original implementation. 2. It incorporates a more robust fix to a bug that was addressed in a [previous PR](#19542). It also adds more comprehensive tests to cover this case. Co-authored-by: UnboundVariable <unbound@gmail.com>
This PR fixes bug #879 where the signature help popup remains visible after typing the closing paren in a call expression.