Skip to content

Conversation

@MichaReiser
Copy link
Member

@MichaReiser MichaReiser commented Jul 10, 2025

Summary

Use the completion kind provided by ty instead of defaulting to Variable for all completions.

Test Plan

Screen.Recording.2025-07-10.at.09.38.06.mov

@MichaReiser MichaReiser added the playground A playground-specific issue label Jul 10, 2025
@MichaReiser MichaReiser force-pushed the micha/completion-kind-playground branch from 2734bbd to 741118c Compare July 10, 2025 07:38
@MichaReiser MichaReiser added the ty Multi-file analysis & type inference label Jul 10, 2025
@MichaReiser MichaReiser enabled auto-merge (squash) July 10, 2025 07:38
@MichaReiser MichaReiser merged commit 5fb2fb9 into main Jul 10, 2025
37 checks passed
@MichaReiser MichaReiser deleted the micha/completion-kind-playground branch July 10, 2025 07:41
@github-actions
Copy link
Contributor

mypy_primer results

No ecosystem changes detected ✅
No memory usage changes detected ✅

UnboundVariable pushed a commit to UnboundVariable/ruff that referenced this pull request Jul 11, 2025
…re_help

* 'main' of https://github.com/astral-sh/ruff:
  Add simple integration tests for all output formats (astral-sh#19265)
  [`flake8-return`] Fix false-positive for variables used inside nested functions in `RET504`  (astral-sh#18433)
  [ty] Add a `--quiet` mode (astral-sh#19233)
  Treat form feed as valid whitespace before a line continuation (astral-sh#19220)
  [ty] Make `check_file` a salsa query (astral-sh#19255)
  [ty] Consolidate submodule resolving code between `types.rs` and `ide_support.rs` (astral-sh#19256)
  [ty] Remove countme from salsa-structs (astral-sh#19257)
  [ty] Improve and document equivalence for module-literal types (astral-sh#19243)
  [ty] Optimize protocol subtyping by removing expensive and unnecessary equivalence check from the top of `Type::has_relation_to()` (astral-sh#19230)
  [ty] Ecosystem analyzer: parallelize, fix race condition (astral-sh#19252)
  [ty] Add completion kind to playground (astral-sh#19251)
  [ty] Deploy ecosystem diff to Cloudflare pages (astral-sh#19234)
  [ty] Add semantic token provider to playground (astral-sh#19232)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

playground A playground-specific issue ty Multi-file analysis & type inference

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants