Skip to content

[ty] Remove vestigial pyvenv.cfg creation in mdtest#18006

Merged
zanieb merged 1 commit intomainfrom
zb/python-env-mdtest
May 10, 2025
Merged

[ty] Remove vestigial pyvenv.cfg creation in mdtest#18006
zanieb merged 1 commit intomainfrom
zb/python-env-mdtest

Conversation

@zanieb
Copy link
Member

@zanieb zanieb commented May 10, 2025

Following #17991, removes some of #17222 which is no longer strictly necessary. I don't actually think it's that ugly to have around? no strong feelings on retaining it or not.

@zanieb zanieb added the testing Related to testing Ruff itself label May 10, 2025
@zanieb zanieb requested a review from carljm as a code owner May 10, 2025 13:44
@zanieb zanieb added the ty Multi-file analysis & type inference label May 10, 2025
@zanieb zanieb added the testing Related to testing Ruff itself label May 10, 2025
@zanieb zanieb requested a review from dcreager as a code owner May 10, 2025 13:44
@zanieb zanieb added the ty Multi-file analysis & type inference label May 10, 2025
@github-actions
Copy link
Contributor

github-actions bot commented May 10, 2025

mypy_primer results

No ecosystem changes detected ✅

@zanieb zanieb force-pushed the zb/python-env-origin branch from 17c64dc to 3439005 Compare May 10, 2025 14:43
@zanieb zanieb force-pushed the zb/python-env-mdtest branch from d1d3b42 to 82b3860 Compare May 10, 2025 14:43
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me!

@zanieb zanieb force-pushed the zb/python-env-origin branch 2 times, most recently from a96d060 to b0d6ac0 Compare May 10, 2025 20:32
Base automatically changed from zb/python-env-origin to main May 10, 2025 20:36
@zanieb zanieb force-pushed the zb/python-env-mdtest branch from 82b3860 to db79108 Compare May 10, 2025 20:49
@zanieb zanieb enabled auto-merge (squash) May 10, 2025 20:49
@zanieb zanieb merged commit 7e8ba2b into main May 10, 2025
32 checks passed
@zanieb zanieb deleted the zb/python-env-mdtest branch May 10, 2025 20:52
Glyphack pushed a commit to Glyphack/ruff that referenced this pull request May 21, 2025
Following astral-sh#17991, removes some of
astral-sh#17222 which is no longer strictly
necessary. I don't actually think it's that ugly to have around? no
strong feelings on retaining it or not.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing Related to testing Ruff itself ty Multi-file analysis & type inference

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants