[flake8-bandit] Mark tuples of string literals as trusted input in S603#17801
Merged
ntBre merged 1 commit intoastral-sh:mainfrom May 5, 2025
Merged
[flake8-bandit] Mark tuples of string literals as trusted input in S603#17801ntBre merged 1 commit intoastral-sh:mainfrom
flake8-bandit] Mark tuples of string literals as trusted input in S603#17801ntBre merged 1 commit intoastral-sh:mainfrom
Conversation
Contributor
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| S603 | 1 | 0 | 1 | 0 | 0 |
Contributor
|
Might be a nitpick, but technically the python type is |
ntBre
reviewed
May 5, 2025
Comment on lines
+206
to
+218
| 44 | # https://github.com/astral-sh/ruff/issues/17798 | ||
| 45 | # Tuple literals are trusted | ||
| 46 | check_output(("literal", "cmd", "using", "tuple"), text=True) | ||
| | ^^^^^^^^^^^^ S603 | ||
| 47 | Popen(("literal", "cmd", "using", "tuple")) | ||
| | | ||
|
|
||
| S603.py:47:1: S603 `subprocess` call: check for execution of untrusted input | ||
| | | ||
| 45 | # Tuple literals are trusted | ||
| 46 | check_output(("literal", "cmd", "using", "tuple"), text=True) | ||
| 47 | Popen(("literal", "cmd", "using", "tuple")) | ||
| | ^^^^^ S603 |
Contributor
There was a problem hiding this comment.
Aren't these both showing that tuples are still flagged? I thought we should expect not to see a diagnostic here now.
Contributor
Author
There was a problem hiding this comment.
Oh shoot, I forgot to comment about that. So, if I run using the check command in this code, no diagnostics are flagged.
from subprocess import Popen, check_output
check_output(("literal", "cmd", "using", "tuple"), text=True)
Popen(("literal", "cmd", "using", "tuple"))$ cargo run -p ruff -- check sample.py --preview --no-cache --select S603
Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.19s
Running `target/debug/ruff check sample2.py --preview --no-cache --select S603`
All checks passed!
I don't know why it's only creating the diagnostics for the snapshot test. Do you have any idea?
Contributor
There was a problem hiding this comment.
Ohhh, I see. The same Python file (S603.py) is passed to both the rules test and the preview_rules case. We're not seeing a snapshot for the preview version because your change is working properly! This snapshot is for the non-preview version, which correctly shows the diagnostic, my mistake.
flake8-bandit] Mark tuple[str] literal as trusted input in S603flake8-bandit] Mark tuples of string literals as trusted input in S603
AlexWaygood
pushed a commit
that referenced
this pull request
May 5, 2025
…`S603` (#17801) <!-- Thank you for contributing to Ruff! To help us out with reviewing, please consider the following: - Does this pull request include a summary of the change? (See below.) - Does this pull request include a descriptive title? - Does this pull request include references to any relevant issues? --> ## Summary Fixes #17798 <!-- What's the purpose of the change? What does it do, and why? --> ## Test Plan Snapshot tests <!-- How was it tested? -->
Glyphack
pushed a commit
to Glyphack/ruff
that referenced
this pull request
May 6, 2025
…`S603` (astral-sh#17801) <!-- Thank you for contributing to Ruff! To help us out with reviewing, please consider the following: - Does this pull request include a summary of the change? (See below.) - Does this pull request include a descriptive title? - Does this pull request include references to any relevant issues? --> ## Summary Fixes astral-sh#17798 <!-- What's the purpose of the change? What does it do, and why? --> ## Test Plan Snapshot tests <!-- How was it tested? -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #17798
Test Plan
Snapshot tests