[flake8-use-pathlib] Fix PTH116 false positive when stat is passed a file descriptor#17709
Merged
MichaReiser merged 7 commits intoastral-sh:mainfrom May 1, 2025
Merged
[flake8-use-pathlib] Fix PTH116 false positive when stat is passed a file descriptor#17709MichaReiser merged 7 commits intoastral-sh:mainfrom
flake8-use-pathlib] Fix PTH116 false positive when stat is passed a file descriptor#17709MichaReiser merged 7 commits intoastral-sh:mainfrom
Conversation
…sed a file descriptor or bytes string
Contributor
|
Contributor
Contributor
Author
|
Fixing the merge conflicts |
MichaReiser
approved these changes
Apr 30, 2025
Contributor
Author
Alright, no problem. So, should I remove the bytes string changes from the other PTH* rules as well? |
Member
|
I realized that the refactor that I did in #17715 will cause merge conflicts in your PRs, I'll resolve them. |
flake8-use-pathlib] Fix PTH116 false positive when stat is passed a file descriptor or bytes stringflake8-use-pathlib] Fix PTH116 false positive when stat is passed a file descriptor
Member
That would be great, yes |
dcreager
added a commit
that referenced
this pull request
May 1, 2025
* main: Improve messages outputted by py-fuzzer (#17764) [`red-knot`] Allow subclasses of Any to be assignable to Callable types (#17717) [red-knot] Increase durability of read-only `File` fields (#17757) [red-knot] Cache source type during semanic index building (#17756) [`flake8-use-pathlib`] Fix `PTH116` false positive when `stat` is passed a file descriptor (#17709) Sync vendored typeshed stubs (#17753)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Contains the same changes to the semantic type inference as #17705.
Fixes #17693.
Test Plan
Snapshot tests.