Skip to content

[red-knot] Don't ignore hidden files by default #17655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MichaReiser merged 1 commit into from
Apr 28, 2025
Merged

[red-knot] Don't ignore hidden files by default #17655

MichaReiser merged 1 commit into from
Apr 28, 2025

Conversation

@thejchap
Copy link
Contributor

@thejchap thejchap commented Apr 27, 2025

Summary

#17626
Update directory walking configuration to not ignore hidden files by default. Matches Ruff's behavior

Test Plan

Snapshot test

@thejchap
Don't ignore hidden files by default
2c8624c 
17626
Update directory walking configuration to not ignore hidden files by
default. Matches Ruff's behavior
@github-actions
Copy link
Contributor

github-actions bot commented Apr 27, 2025

mypy_primer results

Changes were detected when running on open source projects 
vision (https://github.com/pytorch/vision)
+ error[lint:unresolved-import] /tmp/mypy_primer/projects/vision/.github/process_commit.py:13:8: Cannot resolve import `requests`
+ error[lint:invalid-argument-type] /tmp/mypy_primer/projects/vision/.github/process_commit.py:77:47: Argument to this function is incorrect: Expected `int`, found `int | None`
+ error[lint:invalid-argument-type] /tmp/mypy_primer/projects/vision/.github/process_commit.py:77:47: Argument to this function is incorrect: Expected `int`, found `int | None`
+ error[lint:invalid-argument-type] /tmp/mypy_primer/projects/vision/.github/process_commit.py:77:47: Argument to this function is incorrect: Expected `int`, found `int | None`
+ error[lint:invalid-assignment] /tmp/mypy_primer/projects/vision/.github/scripts/run-clang-format.py:48:5: Object of type `TextIOWrapper` is not assignable to `int`
+ warning[lint:possibly-unbound-attribute] /tmp/mypy_primer/projects/vision/.github/scripts/run-clang-format.py:152:17: Attribute `readlines` on type `@Todo(specialized non-generic class) | None` is possibly unbound
+ warning[lint:possibly-unbound-attribute] /tmp/mypy_primer/projects/vision/.github/scripts/run-clang-format.py:153:17: Attribute `readlines` on type `@Todo(specialized non-generic class) | None` is possibly unbound
- Found 2249 diagnostics
+ Found 2256 diagnostics

@AlexWaygood AlexWaygood added the ty Multi-file analysis & type inference label Apr 27, 2025
@thejchap thejchap marked this pull request as ready for review April 27, 2025 21:14
@AlexWaygood AlexWaygood removed their request for review April 27, 2025 21:27
MichaReiser
MichaReiser approved these changes Apr 28, 2025
View reviewed changes
Copy link
Member

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MichaReiser MichaReiser merged commit d224627 into astral-sh:main Apr 28, 2025
34 checks passed
dcreager added a commit that referenced this pull request Apr 28, 2025
@dcreager
Merge branch 'main' into dcreager/legacy-typevar-instance
fdaa4c9 
* main: (37 commits)
  [red-knot] Revert blanket `clippy::too_many_arguments` allow (#17688)
  Add config option to disable `typing_extensions` imports  (#17611)
  ruff_db: render file paths in diagnostics as relative paths if possible
  Bump mypy_primer pin (#17685)
  red_knot_python_semantic: improve `not-iterable` diagnostic
  [red-knot] Allow all callables to be assignable to @Todo-signatures (#17680)
  [`refurb`] Mark fix as safe for `readlines-in-for` (`FURB129`) (#17644)
  Collect preview lint behaviors in separate module (#17646)
  Upgrade Salsa to a more recent commit (#17678)
  [red-knot] TypedDict: No errors for introspection dunder attributes (#17677)
  [`flake8-pyi`] Ensure `Literal[None,] | Literal[None,]` is not autofixed to `None | None` (`PYI061`) (#17659)
  [red-knot] No errors for definitions of `TypedDict`s (#17674)
  Update actions/download-artifact digest to d3f86a1 (#17664)
  [red-knot] Use 101 exit code when there's at least one diagnostic with severity 'fatal' (#17640)
  [`pycodestyle`] Fix duplicated diagnostic in `E712` (#17651)
  [airflow] fix typos `AIR312` (#17673)
  [red-knot] Don't ignore hidden files by default (#17655)
  Update pre-commit hook astral-sh/ruff-pre-commit to v0.11.7 (#17670)
  Update docker/build-push-action digest to 14487ce (#17665)
  Update taiki-e/install-action digest to ab3728c (#17666)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MichaReiser MichaReiser MichaReiser approved these changes

@carljm carljm Awaiting requested review from carljm

@sharkdp sharkdp Awaiting requested review from sharkdp

@dcreager dcreager Awaiting requested review from dcreager

Assignees

No one assigned

Labels

ty Multi-file analysis & type inference

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thejchap @MichaReiser @AlexWaygood