[ruff] Stabilize unnecessary-nested-literal (RUF041)#16648
Merged
ntBre merged 2 commits intomicha/ruff-0.10from Mar 12, 2025
Merged
[ruff] Stabilize unnecessary-nested-literal (RUF041)#16648ntBre merged 2 commits intomicha/ruff-0.10from
ruff] Stabilize unnecessary-nested-literal (RUF041)#16648ntBre merged 2 commits intomicha/ruff-0.10from
Conversation
Summary -- Stabilizes RUF041. The tests are already in the right place, and the docs look good. Test Plan -- 0 issues, 1 [PR] fixing nested literals and unions the day after the rule was added. No changes since then I wonder if the fix in that PR could be relevant for #16639, where I noticed a potential issue with `Union`. It could be unrelated, though. [PR]: #14641
CodSpeed Performance ReportMerging #16648 will degrade performances by 4.6%Comparing Summary
Benchmarks breakdown
|
Contributor
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| RUF041 | 2 | 2 | 0 | 0 | 0 |
Linter (preview)
✅ ecosystem check detected no linter changes.
Contributor
Author
|
These look like true positives to me. Interestingly, it looks like disnake is testing this flattening behavior, so they will probably want to |
MichaReiser
approved these changes
Mar 12, 2025
MichaReiser
pushed a commit
that referenced
this pull request
Mar 13, 2025
Summary -- Stabilizes RUF041. The tests are already in the right place, and the docs look good. Test Plan -- 0 issues, 1 [PR] fixing nested literals and unions the day after the rule was added. No changes since then I wonder if the fix in that PR could be relevant for #16639, where I noticed a potential issue with `Union`. It could be unrelated, though. [PR]: #14641
MichaReiser
pushed a commit
that referenced
this pull request
Mar 13, 2025
Summary -- Stabilizes RUF041. The tests are already in the right place, and the docs look good. Test Plan -- 0 issues, 1 [PR] fixing nested literals and unions the day after the rule was added. No changes since then I wonder if the fix in that PR could be relevant for #16639, where I noticed a potential issue with `Union`. It could be unrelated, though. [PR]: #14641
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stabilizes RUF041. The tests are already in the right place, and the docs look good.
Test Plan
0 issues, 1 PR fixing nested literals and unions the day after the rule was added. No changes since then
I wonder if the fix in that PR could be relevant for #16639, where I noticed a potential issue with
Union. It could be unrelated, though.