Check diagnostic refresh support from client capability#15014
Merged
dhruvmanila merged 1 commit intomainfrom Dec 16, 2024
Merged
Check diagnostic refresh support from client capability#15014dhruvmanila merged 1 commit intomainfrom
dhruvmanila merged 1 commit intomainfrom
Conversation
Contributor
|
This comment was marked as resolved.
This comment was marked as resolved.
MichaReiser
approved these changes
Dec 16, 2024
dcreager
added a commit
that referenced
this pull request
Dec 16, 2024
* main: (25 commits) [`pydocstyle`] Skip leading whitespace for `D403` (#14963) Update pre-commit dependencies (#15008) Check diagnostic refresh support from client capability (#15014) Update Rust crate colored to v2.2.0 (#15010) Update dependency monaco-editor to v0.52.2 (#15006) Update Rust crate thiserror to v2.0.7 (#15005) Update Rust crate serde to v1.0.216 (#15004) Update Rust crate libc to v0.2.168 (#15003) Update Rust crate fern to v0.7.1 (#15002) Update Rust crate chrono to v0.4.39 (#15001) Update Rust crate bstr to v1.11.1 (#15000) Update NPM Development dependencies (#14999) Update dependency ruff to v0.8.3 (#15007) Pin mdformat plugins in pre-commit (#14992) Use stripping block (`|-`) for page descriptions (#14980) [`perflint`] Fix panic in `perf401` (#14971) Improve the documentation of E201/E202 (#14983) [ruff_python_ast] Add name and default functions to TypeParam. (#14964) [red-knot] Emit an error if a bare `Annotated` or `Literal` is used in a type expression (#14973) [red-knot] Fix bugs relating to assignability of dynamic `type[]` types (#14972) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Per the LSP spec, the property name is
workspace.diagnosticswith ansat the end but thelsp-typesdependency usesworkspace.diagnostic(without ans). Our fork contains this fix (astral-sh/lsp-types@0f58d62) so we should avoid the hardcoded value.The implication of this is that the client which doesn't support workspace refresh capability didn't support the dynamic configuration feature because the server would always send the workspace refresh request but the client would ignore it. We have a fallback logic to publish the diagnostics instead:
ruff/crates/ruff_server/src/server/api/notifications/did_change_watched_files.rs
Lines 28 to 40 in 5f6fc39
fixes: #15013
Test Plan
VS Code
Screen.Recording.2024-12-16.at.2.28.32.PM.mov
Neovim
Screen.Recording.2024-12-16.at.3.04.00.PM.mov