[ruff] Skip SQLModel base classes for mutable-class-default (RUF012)#14949
Merged
dylwil3 merged 3 commits intoastral-sh:mainfrom Dec 13, 2024
Merged
[ruff] Skip SQLModel base classes for mutable-class-default (RUF012)#14949dylwil3 merged 3 commits intoastral-sh:mainfrom
ruff] Skip SQLModel base classes for mutable-class-default (RUF012)#14949dylwil3 merged 3 commits intoastral-sh:mainfrom
Conversation
Contributor
|
dylwil3
requested changes
Dec 13, 2024
Collaborator
dylwil3
left a comment
There was a problem hiding this comment.
Thank you so much! Just one request for some more tests and then it looks good to me
ruff] Skip SQLModel base classes for mutable-class-default (RUF012)
dylwil3
approved these changes
Dec 13, 2024
Collaborator
dylwil3
left a comment
There was a problem hiding this comment.
LGTM - thank you again for your contribution!
dcreager
added a commit
that referenced
this pull request
Dec 13, 2024
* main: [red-knot] Display definition range in trace logs (#14955) [red-knot] Move the `ClassBase` enum to its own submodule (#14957) [red-knot] mdtest: python version requirements (#14954) [airflow]: Import modules that has been moved to airflow providers (AIR303) (#14764) [red-knot] Support `typing.TYPE_CHECKING` (#14952) Add tracing support to mdtest (#14935) Re-enable the fuzzer job on PRs (#14953) [red-knot] Improve `match` mdtests (#14951) Rename `custom-typeshed-dir`, `target-version` and `current-directory` CLI options (#14930) [red-knot] Add narrowing for 'while' loops (#14947) [`ruff`] Skip SQLModel base classes for `mutable-class-default` (`RUF012`) (#14949) [red-knot] Tests for 'while' loop boundness (#14944)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #14892, by adding
sqlmodel.SQLModelto the list of classes with default copy semantics.Test Plan
Added a test into
RUF012.pycontaining the example from the original issue.