Conversation
AlexWaygood
approved these changes
Nov 28, 2024
It looks like we want to use `returns_bool()` here. `bool()` is equal to `False`, and we infer `Literal[False]` for it. Which means that the test here will fail as soon as we treat the body of this `if` as unreachable.
df1a3e2 to
70b67ae
Compare
Contributor
|
sharkdp
added a commit
that referenced
this pull request
Nov 28, 2024
## Summary Similar to #14652, but now with conditions that are `Literal[True]` (instead of `Literal[False]`), where we want them to be `bool`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
It looks like we want to use
returns_bool()here.bool()is equal toFalse, and we inferLiteral[False]for it. Which means that the test here will fail as soon as we treat the body of thisifas unreachable.