Merged
Conversation
AlexWaygood
approved these changes
Nov 16, 2024
Member
There was a problem hiding this comment.
Thank you!
We can still run the tests using
cargo test -p red_knot_workspace -- --ignored linter_af linter_gz. This is also why I left thecrates/ruff_linter/entries in the allow list for now, even if they will get out of sync. But let me know if I should rather remove them.
I think it makes sense to leave the allowlist entries for the linter crate in there. Leaving the entries there probably allows us to examine a specific file in isolation more easily when we're running these tests manually using --ignored. That in turn may make it easier to whittle down the files we panic on.
Contributor
|
dylwil3
pushed a commit
to dylwil3/ruff
that referenced
this pull request
Nov 17, 2024
## Summary Disable the no-panic tests for the linter corpus, as there are too many problems right now, requiring linter-contributors to add their test files to the allow-list. We can still run the tests using `cargo test -p red_knot_workspace -- --ignored linter_af linter_gz`. This is also why I left the `crates/ruff_linter/` entries in the allow list for now, even if they will get out of sync. But let me know if I should rather remove them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Disable the no-panic tests for the linter corpus, as there are too many problems right now, requiring linter-contributors to add their test files to the allow-list.
We can still run the tests using
cargo test -p red_knot_workspace -- --ignored linter_af linter_gz. This is also why I left thecrates/ruff_linter/entries in the allow list for now, even if they will get out of sync. But let me know if I should rather remove them.