[refurb] Avoid triggering hardcoded-string-charset for reordered sets#14233
Merged
charliermarsh merged 1 commit intomainfrom Nov 9, 2024
Merged
[refurb] Avoid triggering hardcoded-string-charset for reordered sets#14233charliermarsh merged 1 commit intomainfrom
refurb] Avoid triggering hardcoded-string-charset for reordered sets#14233charliermarsh merged 1 commit intomainfrom
Conversation
abe6f61 to
7c151c2
Compare
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
It's only safe to enforce the
x in "1234567890"case ifxis exactly one character, since the set on the right has been reordered as compared tostring.digits. We can't know ifxis exactly one character unless it's a literal. And if it's a literal, well, it's kind of silly code in the first place?Closes #13802.