Fix server panic when undoing an edit#14010
Merged
MichaReiser merged 3 commits intomainfrom Nov 1, 2024
Merged
Conversation
Contributor
|
dhruvmanila
approved these changes
Nov 1, 2024
Member
dhruvmanila
left a comment
There was a problem hiding this comment.
Nice! Thanks for looking into it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #13674 and possibly astral-sh/ruff-vscode#607
The
TextDocument::apply_changescontained some naive logic to reuse theLineIndexif it happened that the content didn't change.Hower, that logic was incorrect because it compared the
new_contentwith the original document content rather than the contentfrom the last iteration. This resulted in a stale
LineIndexwhen an edit reverts the content to the original content.I decided to remove the optimization alltogether because it's too naive to be useful in practice. We could apply a logic similar
to Biome's, we avoid recomputing the LineIndex when the previous edits only changed lines further down in the document. source
However, I don't think that this is a big perf bottlneck. Computing a
LineIndexis relatively cheap.Test Plan
I added a unit test