[red-knot] feat: add StringLiteral and LiteralString comparison#13634
Merged
carljm merged 10 commits intoastral-sh:mainfrom Oct 5, 2024
Merged
[red-knot] feat: add StringLiteral and LiteralString comparison#13634carljm merged 10 commits intoastral-sh:mainfrom
StringLiteral and LiteralString comparison#13634carljm merged 10 commits intoastral-sh:mainfrom
Conversation
Contributor
|
carljm
reviewed
Oct 5, 2024
Contributor
carljm
left a comment
There was a problem hiding this comment.
Looks great! I think we need a few more tests, in one case to catch a bug that also needs fixing, and in the other just for completeness.
10408e9 to
5190a3f
Compare
AlexWaygood
reviewed
Oct 5, 2024
AlexWaygood
reviewed
Oct 5, 2024
e259ccf to
768a412
Compare
carljm
reviewed
Oct 5, 2024
AlexWaygood
reviewed
Oct 5, 2024
Member
AlexWaygood
left a comment
There was a problem hiding this comment.
You need to switch to using the new APIs you introduced an hour ago in 1c2cafc ;)
1f97dc5 to
171302b
Compare
AlexWaygood
reviewed
Oct 5, 2024
carljm
approved these changes
Oct 5, 2024
sharkdp
added a commit
that referenced
this pull request
Oct 14, 2024
Implements inference for `BytesLiteral` comparisons along the lines of #13634.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements string lietral comparisons and fallbacks to
strinstance forLiteralString.Completes an item in #13618
Test Plan