Handle singular case for incompatible rules warning#13212
Merged
MichaReiser merged 5 commits intoastral-sh:mainfrom Sep 2, 2024
Merged
Handle singular case for incompatible rules warning#13212MichaReiser merged 5 commits intoastral-sh:mainfrom
MichaReiser merged 5 commits intoastral-sh:mainfrom
Conversation
- Updated the code to call `warn_user_once!` twice, handling both singular and plural cases separately. - Ensures the warning message is grammatically correct when only one incompatible rule is present.
Co-authored-by: Micha Reiser <micha@reiser.io>
CodSpeed Performance ReportMerging #13212 will improve performances by 4.9%Comparing Summary
Benchmarks breakdown
|
auto-merge was automatically disabled
September 2, 2024 12:06
Head branch was pushed to by a user without write access
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running Ruff format I got a slightly confusing message. The Ruff message was confusing, because it was in plural, even though only a single rule was giving me this error.
Summary
warn_user_once!twice, handling both singular and plural cases separately.Test Plan
It's a minor change, so the automatic tests should cover this.