Skip to content

Basic concurrent checking#13049

Merged
MichaReiser merged 3 commits intomainfrom
concurrent=checking
Aug 24, 2024
Merged

Basic concurrent checking#13049
MichaReiser merged 3 commits intomainfrom
concurrent=checking

Conversation

@MichaReiser
Copy link
Copy Markdown
Member

@MichaReiser MichaReiser commented Aug 22, 2024 •
edited
Loading

Summary

This PR makes workspace.check to check the files concurrently.

This PR doesn't explore more advanced scheduling. For example, we could try to not only schedule the workspace files
but also the dependencies of those files. This would give us better performance where a project has few first-party modules but depends on many third-party modules.

The main downside of concurrent checking is that the logs become harder to read, especially when using -vvv because the output of different threads is intertwined. I don't have a good solution for this yet other than using RAYON_NUM_THREADS=1 to explicitly fall-back to a single thread.

Test Plan

Checking black goes down from 108ms to 34ms (12 cores)

Main

black (cold)
Benchmark 1: knot
  Time (mean ± σ):     125.2 ms ±   3.8 ms    [User: 89.3 ms, System: 35.7 ms]
  Range (min … max):   117.7 ms … 133.3 ms    24 runs
 
  Warning: Ignoring non-zero exit code.
 
jinja (cold)
Benchmark 1: knot
  Time (mean ± σ):     139.1 ms ±   9.2 ms    [User: 100.1 ms, System: 38.8 ms]
  Range (min … max):   125.0 ms … 155.7 ms    22 runs
 
  Warning: Ignoring non-zero exit code.
 
isort (cold)
Benchmark 1: knot
  Time (mean ± σ):      85.2 ms ±   2.3 ms    [User: 60.1 ms, System: 25.0 ms]
  Range (min … max):    80.6 ms …  89.1 ms    32 runs
 
  Warning: Ignoring non-zero exit code.

Concurrent

uv run benchmark  --min-runs=3 --knot
black (cold)
Benchmark 1: knot
  Time (mean ± σ):      36.1 ms ±   1.1 ms    [User: 125.6 ms, System: 71.7 ms]
  Range (min … max):    33.3 ms …  39.4 ms    77 runs
 
  Warning: Ignoring non-zero exit code.
 
jinja (cold)
Benchmark 1: knot
  Time (mean ± σ):      32.6 ms ±   1.5 ms    [User: 140.8 ms, System: 88.7 ms]
  Range (min … max):    29.5 ms …  36.4 ms    88 runs
 
  Warning: Ignoring non-zero exit code.
 
isort (cold)
Benchmark 1: knot
  Time (mean ± σ):      30.7 ms ±   1.2 ms    [User: 82.4 ms, System: 46.7 ms]
  Range (min … max):    28.4 ms …  34.4 ms    89 runs
 
  Warning: Ignoring non-zero exit code.

@MichaReiser MichaReiser added the ty Multi-file analysis & type inference label Aug 22, 2024
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Aug 22, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #13049 will not alter performance

Comparing concurrent=checking (acbed7c) with main (1f2cb09)

Summary

✅ 32 untouched benchmarks

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 22, 2024 •
edited
Loading

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

@MichaReiser MichaReiser changed the title A very basic prototype for concurrent checking Basic concurrent checking Aug 23, 2024
@MichaReiser MichaReiser marked this pull request as ready for review August 23, 2024 08:17
carljm
carljm approved these changes Aug 23, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@carljm carljm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@MichaReiser MichaReiser merged commit ecab04e into main Aug 24, 2024
@MichaReiser MichaReiser deleted the concurrent=checking branch August 24, 2024 08:53
AlexWaygood added a commit that referenced this pull request Aug 28, 2024
@AlexWaygood
[red-knot] Add docs on using RAYON_NUM_THREADS for better logging
4c9d9ed 
Followup to #13049. We check files concurrently now; to get readable logs, you probably want to switch that off
@AlexWaygood AlexWaygood mentioned this pull request Aug 28, 2024
Merged
AlexWaygood added a commit that referenced this pull request Aug 28, 2024
@AlexWaygood
[red-knot] Add docs on using RAYON_NUM_THREADS for better logging (#…
c6023c0 
…13140)

Followup to #13049. We check files concurrently now; to get readable
logs, you probably want to switch that off
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carljm carljm carljm approved these changes

@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood

Assignees

No one assigned

Labels

ty Multi-file analysis & type inference

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MichaReiser @carljm