CodSpeed Performance Report

Merging #13023 will improve performances by 10.62%

_{Comparing vdwees:main (ad23c48) with main (cfe25ab)}

Summary

⚡ 1 improvements
✅ 31 untouched benchmarks

Benchmarks breakdown

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Thanks. This does make sense to me. However, it does mean that the rule now deviates from the upstream rule (I'm not sure if flake8-async has access to the target Python version). @AlexWaygood what's your take on this?

https://github.com/python-trio/flake8-async/blob/225f15a98db4bb8ce4600127fd0fe90bc5c9c04b/flake8_async/visitors/visitors.py#L43C7-L60

It would be great if we can add a test demonstrating that this is working as expected (flags asyncio but not anyio)

You can add the test here

and you can use the code below (you have to change the path to the python file)

    #[test]
    fn async109_python_310_or_odler() -> Result<()> {
        let diagnostics = test_path(
            Path::new("flake8_async").join("path_to_test_File"),
            &LinterSettings {
                target_version: PythonVersion::Py310,
                ..LinterSettings::for_rule(Rule::AsyncFunctionWithTimeout)
            },
        )?;
        assert_messages!(diagnostics);
        Ok(())
    }

Thanks. This does make sense to me. However, it does mean that the rule now deviates from the upstream rule (I'm not sure if flake8-async has access to the target Python version). @AlexWaygood what's your take on this?

Yeah, this change definitely makes sense to me! There are third-party libraries backporting asyncio.timeout to earlier Python versions, but I think that's irrelevant to the changes this PR is making. So this looks good, once it has a test added!