Skip to content

Update OpenAI excluded notebooks from ecosystem checks#12867

Merged
dhruvmanila merged 1 commit intomainfrom
dhruv/ecosystem-notebooks
Aug 14, 2024
Merged

Update OpenAI excluded notebooks from ecosystem checks#12867
dhruvmanila merged 1 commit intomainfrom
dhruv/ecosystem-notebooks

Conversation

@dhruvmanila
Copy link
Copy Markdown
Member

@dhruvmanila dhruvmanila commented Aug 13, 2024

Summary

Follow-up to #12864, we don't need to exclude these notebooks anymore.

Test plan

  • Make sure that ecosystem checks are green.

@dhruvmanila dhruvmanila added the ci Related to internal CI tooling label Aug 13, 2024
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Aug 13, 2024

CodSpeed Performance Report

Merging #12867 will not alter performance

Comparing dhruv/ecosystem-notebooks (cdc471c) with main (d0ac38f)

Summary

✅ 32 untouched benchmarks

Base automatically changed from dhruv/vscode-language-id to main August 13, 2024 16:39
@dhruvmanila dhruvmanila force-pushed the dhruv/ecosystem-notebooks branch from d1fed86 to 26bb45a Compare August 13, 2024 16:40
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 13, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

@dhruvmanila
Copy link
Copy Markdown
Member Author

dhruvmanila commented Aug 13, 2024

Um, this is confusing as I've checked it locally and there were no parse errors. Going to re-run.

@dhruvmanila dhruvmanila force-pushed the dhruv/ecosystem-notebooks branch from 26bb45a to cdc471c Compare August 13, 2024 17:25
@dhruvmanila
Copy link
Copy Markdown
Member Author

I verified that all 3 notebooks highlighted in the ecosystem checks are actually invalid because the cells are marked as "code" without any metadata and it contains plain text / markdown.

I'm not sure why there are no parse errors in the linter section.

@dhruvmanila dhruvmanila changed the title Remove exclude from openai/openai-cookbook in ecosystem Update OpenAI excluded notebooks from ecosystem checks Aug 13, 2024
@dhruvmanila dhruvmanila merged commit 89c8b49 into main Aug 14, 2024
@dhruvmanila dhruvmanila deleted the dhruv/ecosystem-notebooks branch August 14, 2024 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Related to internal CI tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants