Treat type(Protocol) et al as metaclass base#12770
Merged
charliermarsh merged 5 commits intomainfrom Aug 9, 2024
Merged
Conversation
charliermarsh
commented
Aug 9, 2024
charliermarsh
commented
Aug 9, 2024
| | ["abc", "ABCMeta"] | ||
| | ["enum", "EnumMeta" | "EnumType"] | ||
| ) | ||
| }), |
Member
Author
There was a problem hiding this comment.
This is the only logic change.
charliermarsh
commented
Aug 9, 2024
charliermarsh
commented
Aug 9, 2024
8d67ca4 to
19f2487
Compare
AlexWaygood
requested changes
Aug 9, 2024
CodSpeed Performance ReportMerging #12770 will not alter performanceComparing Summary
|
Contributor
|
c537a73 to
4be4af0
Compare
AlexWaygood
approved these changes
Aug 9, 2024
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Member
Author
|
Thanks Alex! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #12736.