[ruff_linter] - Use LibCST in adjust_indentation for mixed whitespace#12740
Merged
MichaReiser merged 6 commits intoastral-sh:mainfrom Aug 8, 2024
Merged
[ruff_linter] - Use LibCST in adjust_indentation for mixed whitespace#12740MichaReiser merged 6 commits intoastral-sh:mainfrom
ruff_linter] - Use LibCST in adjust_indentation for mixed whitespace#12740MichaReiser merged 6 commits intoastral-sh:mainfrom
Conversation
CodSpeed Performance ReportMerging #12740 will not alter performanceComparing Summary
|
5b03a5d to
d165c3e
Compare
This reverts commit 3e2f778.
Contributor
|
Member
|
This seems like a pretty big regression. I think I would prefer just to disable the fix in case there's mixed-indentation than regressing performance by that much. |
Contributor
Author
|
Yeah, that is not ideal as is. I'd like to try one more alternative approach, which does already include detecting mixed indentation. |
ruff_linter] - Remove dedent_to usage from adjust_indentation helperruff_linter] - Use LibCST in adjust_indentation for mixed whitespace
MichaReiser
approved these changes
Aug 8, 2024
f9db08e to
d922997
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
dedent_tofunction has a difficult time with mixed whitespace.The code now conditionally uses the LibCST method if there is mixed whitespace.
Fixes #12707
Test Plan
cargo test