Merged
Conversation
90cf86e to
0bf44b7
Compare
1fa1770 to
f2582fd
Compare
CodSpeed Performance ReportMerging #12681 will not alter performanceComparing Summary
|
Contributor
|
4d4c5c8 to
faf316b
Compare
MichaReiser
commented
Aug 14, 2024
Contributor
|
Hey! Any updates about this? Do we have any sort of playground for red knot at the moment? |
Member
Author
|
No, there's no update. This is blocked on adding WASM support to salsa. See https://salsa.zulipchat.com/#narrow/stream/333573-Contributing-to-Salsa/topic/WASM.20support |
Member
Author
|
I plan to pick this up again on the side. It's now unblocked as we use salsa's new fixpoint infrastructure that doesn't rely on panics to resolve cycles. |
c5e07db to
f75f360
Compare
This comment was marked as resolved.
This comment was marked as resolved.
4be75de to
c5b9398
Compare
Contributor
|
c5b9398 to
370fa9e
Compare
370fa9e to
2f7c8e3
Compare
dcreager
added a commit
that referenced
this pull request
Mar 18, 2025
* main: [playground] Avoid concurrent deployments (#16834) [red-knot] Infer `lambda` return type as `Unknown` (#16695) [red-knot] Move `name` field on parameter kind (#16830) [red-knot] Emit errors for more AST nodes that are invalid (or only valid in specific contexts) in type expressions (#16822) [playground] Use cursor for clickable elements (#16833) [red-knot] Deploy playground on main (#16832) Red Knot Playground (#12681) [syntax-errors] PEP 701 f-strings before Python 3.12 (#16543)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a playground for Red Knot
Screencast.from.2024-08-14.10-33-54.webm
Sharing does work 😆 I just forgot to start wrangler.
It supports:
Future extensions:
pyproject.tomlwould just be another file.Blockers
Salsa usescatch_unwindto break cycles, which Red Knot uses extensively when inferring types in the standard library.However, WASM (at least
wasm32-unknown-unknown) doesn't supportcatch_unwindtoday, so the playground always crashes when the type inference encounters a cycle.I created a discussion in the salsa zulip to see if it would be possible to not use catch unwind to break cycles.Rust tracking issue for WASM catch unwind supportI tried to build the WASM with the nightly compiler option but ran into problems because wasm-bindgen doesn't support WASM-exceptions. We could try to write the binding code by hand.Another alternative is to usewasm32-unknown-emscriptenbut it's rather painful to build