Skip to content

Remove leftover debug log#12360

Merged
dhruvmanila merged 1 commit intomainfrom
dhruv/remove-debug
Jul 17, 2024
Merged

Remove leftover debug log#12360
dhruvmanila merged 1 commit intomainfrom
dhruv/remove-debug

Conversation

@dhruvmanila
Copy link
Copy Markdown
Member

This was a leftover from #12299

@dhruvmanila dhruvmanila added the internal An internal refactor or improvement label Jul 17, 2024
@dhruvmanila dhruvmanila merged commit 6e0cbe0 into main Jul 17, 2024
@dhruvmanila dhruvmanila deleted the dhruv/remove-debug branch July 17, 2024 12:22
@github-actions
Copy link
Copy Markdown
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

dhruvmanila added a commit that referenced this pull request Jul 18, 2024
## Summary

This PR updates the settings index building logic in the language server
to consider the fallback settings for applying ignore filters in
`WalkBuilder` and the exclusion via `exclude` / `extend-exclude`.

This flow matches the one in the `ruff` CLI where the root settings is
built by (1) finding the workspace setting in the ancestor directory (2)
finding the user configuration if that's missing and (3) fallback to
using the default configuration.

Previously, the index building logic was being executed before (2) and
(3). This PR reverses the logic so that the exclusion /
`respect_gitignore` is being considered from the default settings if
there's no workspace / user settings. This has the benefit that the
server no longer enters the `.git` directory or any other excluded
directory when a user opens a file in the home directory.

Related to #11366

## Test plan

Opened a test file from the home directory and confirmed with the debug
trace (removed in #12360) that the server excludes the `.git` directory
when indexing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal An internal refactor or improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants