Skip to content

Use Box<str> for `Identifier#12100

Closed
MichaReiser wants to merge 2 commits intomainfrom
name-box-str
Closed

Use Box<str> for `Identifier#12100
MichaReiser wants to merge 2 commits intomainfrom
name-box-str

Conversation

@MichaReiser
Copy link
Copy Markdown
Member

  • Use smol_str for Identifier
  • Use boxed string for name

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Jun 29, 2024

CodSpeed Performance Report

Merging #12100 will improve performances by 7.68%

Comparing name-box-str (e41728a) with main (47b2273)

Summary

⚡ 4 improvements
✅ 26 untouched benchmarks

Benchmarks breakdown

Benchmark main name-box-str Change
parser[large/dataset.py] 5.4 ms 5 ms +7.68%
parser[numpy/ctypeslib.py] 1,007.9 µs 958.4 µs +5.16%
parser[pydantic/types.py] 2.2 ms 2.1 ms +5.25%
parser[unicode/pypinyin.py] 329.3 µs 314 µs +4.85%

@MichaReiser
Copy link
Copy Markdown
Member Author

Closing in favor of #12101 which shows the most promising results

@MichaReiser MichaReiser deleted the name-box-str branch August 12, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant