Skip to content

[refurb] Fix misbehavior of operator.itemgetter when getter param is a tuple#11774

Merged
charliermarsh merged 3 commits intoastral-sh:mainfrom
Embers-of-the-Fire:fix-issue-#11714
Jun 7, 2024
Merged

[refurb] Fix misbehavior of operator.itemgetter when getter param is a tuple#11774
charliermarsh merged 3 commits intoastral-sh:mainfrom
Embers-of-the-Fire:fix-issue-#11714

Conversation

@Embers-of-the-Fire
Copy link
Copy Markdown
Contributor

Summary

This should fix #11714.

Test Plan

Tested with the example code mentioned in the issue.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Jun 6, 2024

CodSpeed Performance Report

Merging #11774 will not alter performance

Comparing Embers-of-the-Fire:fix-issue-#11714 (5fba1c6) with Embers-of-the-Fire:fix-issue-#11714 (4bd264e)

Summary

✅ 30 untouched benchmarks

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 6, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@charliermarsh charliermarsh self-assigned this Jun 7, 2024
@charliermarsh charliermarsh added the bug Something isn't working label Jun 7, 2024
Copy link
Copy Markdown
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@charliermarsh charliermarsh changed the title [Bug fix] Fix misbehaviour of operator.itemgetter when the getter param is a tuple [refurb] Fix misbehavior of operator.itemgetter when the getter param is a tuple Jun 7, 2024
@charliermarsh charliermarsh changed the title [refurb] Fix misbehavior of operator.itemgetter when the getter param is a tuple [refurb] Fix misbehavior of operator.itemgetter when getter param is a tuple Jun 7, 2024
@charliermarsh charliermarsh enabled auto-merge (squash) June 7, 2024 03:07
@charliermarsh charliermarsh merged commit ea27445 into astral-sh:main Jun 7, 2024
@Embers-of-the-Fire Embers-of-the-Fire deleted the fix-issue-#11714 branch June 7, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FURB118, lambda x: x[I, ii] should be itemgetter((I, ii)), instead of itemgetter(I, ii)

2 participants