Use enum values instead of struct with single field#11629
Merged
dhruvmanila merged 1 commit intodhruv/parser-phase-2from May 31, 2024
Merged
Use enum values instead of struct with single field#11629dhruvmanila merged 1 commit intodhruv/parser-phase-2from
dhruvmanila merged 1 commit intodhruv/parser-phase-2from
Conversation
dhruvmanila
added a commit
that referenced
this pull request
May 31, 2024
dhruvmanila
added a commit
that referenced
this pull request
May 31, 2024
## Summary This PR is a follow-up to #11475 to use enum values where there's struct with a single field. The main motivation to use struct was to keep the snapshot update to a minimum which allows me to validate it. Now that the validation is done, we can revert it back. ## Test Plan Update the snapshots.
dhruvmanila
added a commit
that referenced
this pull request
May 31, 2024
dhruvmanila
added a commit
that referenced
this pull request
Jun 3, 2024
## Summary This PR is a follow-up to #11475 to use enum values where there's struct with a single field. The main motivation to use struct was to keep the snapshot update to a minimum which allows me to validate it. Now that the validation is done, we can revert it back. ## Test Plan Update the snapshots.
dhruvmanila
added a commit
that referenced
this pull request
Jun 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is a follow-up to #11475 to use enum values where there's struct with a single field. The main motivation to use struct was to keep the snapshot update to a minimum which allows me to validate it. Now that the validation is done, we can revert it back.
Test Plan
Update the snapshots.