Rename Program to Parsed, shorten tokens_in_range#11627
Merged
dhruvmanila merged 1 commit intodhruv/parser-phase-2from May 31, 2024
Merged
Rename Program to Parsed, shorten tokens_in_range#11627dhruvmanila merged 1 commit intodhruv/parser-phase-2from
Program to Parsed, shorten tokens_in_range#11627dhruvmanila merged 1 commit intodhruv/parser-phase-2from
Conversation
CodSpeed Performance ReportMerging #11627 will improve performances by 28.24%Comparing Summary
Benchmarks breakdown
|
dhruvmanila
added a commit
that referenced
this pull request
May 31, 2024
## Summary This PR renames `Program` to `Parsed` and shortens the `tokens_in_range` to `in_range`. The `Program` terminology is used in `red_knot` and this rename is to avoid the conflict. The `tokens_in_range` is usually used as `tokens.tokens_in_range` which suggests that the "tokens" word is repeated, so let's shorten it.
dhruvmanila
added a commit
that referenced
this pull request
Jun 3, 2024
## Summary This PR renames `Program` to `Parsed` and shortens the `tokens_in_range` to `in_range`. The `Program` terminology is used in `red_knot` and this rename is to avoid the conflict. The `tokens_in_range` is usually used as `tokens.tokens_in_range` which suggests that the "tokens" word is repeated, so let's shorten it.
dhruvmanila
added a commit
that referenced
this pull request
Jun 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR renames
ProgramtoParsedand shortens thetokens_in_rangetoin_range.The
Programterminology is used inred_knotand this rename is to avoid the conflict. Thetokens_in_rangeis usually used astokens.tokens_in_rangewhich suggests that the "tokens" word is repeated, so let's shorten it.