Classify match not foo as keyword#11626
Merged
dhruvmanila merged 1 commit intodhruv/parser-phase-2from May 31, 2024
Merged
Conversation
dhruvmanila
commented
May 31, 2024
Comment on lines
3574
to
3576
| | TokenKind::Ellipsis | ||
| | TokenKind::Not | ||
| | TokenKind::Await |
CodSpeed Performance ReportMerging #11626 will improve performances by 28.14%Comparing Summary
Benchmarks breakdown
|
dhruvmanila
added a commit
that referenced
this pull request
May 31, 2024
## Summary
This PR fixes a bug to classify `match` as a keyword for:
```py
match not foo:
case _: ...
```
## Test Plan
This PR also adds a bunch of test cases around the classification of
`match` token as a keyword or an identifier, including speculative
parsing.
dhruvmanila
added a commit
that referenced
this pull request
Jun 3, 2024
## Summary
This PR fixes a bug to classify `match` as a keyword for:
```py
match not foo:
case _: ...
```
## Test Plan
This PR also adds a bunch of test cases around the classification of
`match` token as a keyword or an identifier, including speculative
parsing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a bug to classify
matchas a keyword for:Test Plan
This PR also adds a bunch of test cases around the classification of
matchtoken as a keyword or an identifier, including speculative parsing.