ruff server: Support setting to prioritize project configuration over editor configuration#11086
Merged
snowsignal merged 4 commits intomainfrom Apr 26, 2024
Merged
Conversation
9637979 to
86ff807
Compare
86ff807 to
51b5c51
Compare
Contributor
|
38b3b60 to
afbfabe
Compare
Member
charliermarsh
left a comment
There was a problem hiding this comment.
I wonder if this should be an enum, rather than a bool? That way, we can associate documentation with each variant too, which seems like it would be helpful.
Contributor
Author
@MichaReiser made a similar comment here. I think that's what I plan to go with :) |
Member
|
Oops, I swear I didn't see that! |
Contributor
Author
|
No worries 😄 |
51b5c51 to
a71e3ed
Compare
2a2997f to
f4ad8e8
Compare
Member
charliermarsh
left a comment
There was a problem hiding this comment.
The code looks good, I'm just not sold on the names...
Member
|
I think @MichaReiser will have good advice on the naming and documentation. |
Member
Lol no 😆 I commented in the other PR that I don't have good naming suggestions haha |
MichaReiser
approved these changes
Apr 25, 2024
…ce', rename variants, and introduce a third, editor-only variant.
c8b6b56 to
e58c8b6
Compare
snowsignal
added a commit
to astral-sh/ruff-vscode
that referenced
this pull request
May 17, 2024
) ## Summary Fixes #425 (though only in the pre-release version, since this is a feature for the new LSP server) This is a follow-up to #456. A new setting has been introduced, `Prioritize File Configuration`, which tells the extension to prioritize settings from discovered TOML files over extension settings. Extension settings will still be used when a set field in the extension is not set in the file configuration. ## Test Plan Refer to astral-sh/ruff#11086 for a test plan.
snowsignal
added a commit
to astral-sh/ruff-vscode
that referenced
this pull request
May 17, 2024
) ## Summary Fixes #425 (though only in the pre-release version, since this is a feature for the new LSP server) This is a follow-up to #456. A new setting has been introduced, `Prioritize File Configuration`, which tells the extension to prioritize settings from discovered TOML files over extension settings. Extension settings will still be used when a set field in the extension is not set in the file configuration. ## Test Plan Refer to astral-sh/ruff#11086 for a test plan.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is intended to address astral-sh/ruff-vscode#425, and is a follow-up to #11062.
A new client setting is now supported by the server,
prioritizeFileConfiguration. This is a boolean setting (default:false) that, if set totrue, will instruct the configuration resolver to prioritize file configuration (aka discovered TOML files) over configuration passed in by the editor.A corresponding extension PR has been opened, which makes this setting available for VS Code: astral-sh/ruff-vscode#457.
Test Plan
To test this with VS Code, you'll need to check out the VS Code PR that adds this setting.
The test process is similar to #11062, but in scenarios where the editor configuration would take priority over file configuration, file configuration should take priority.