Remove LALRPOP based parser#10998
Merged
dhruvmanila merged 1 commit intodhruv/parserfrom Apr 17, 2024
Merged
Conversation
CodSpeed Performance ReportMerging #10998 will degrade performances by 4.92%Comparing Summary
Benchmarks breakdown
|
7ec230a to
a2e71a8
Compare
d50ae76 to
0e2cf2d
Compare
0e2cf2d to
b87e363
Compare
4beb382 to
4a382e5
Compare
Base automatically changed from
dhruv/preserve-comma-with-pep-646
to
dhruv/parser
April 17, 2024 12:48
b87e363 to
6868313
Compare
Member
Author
|
I'm going to make sure the ecosystem checks are all good and then merge even though I've ran them locally |
Contributor
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| E999 | 2 | 1 | 1 | 0 | 0 |
Linter (preview)
ℹ️ ecosystem check detected linter changes. (+1 -1 violations, +0 -0 fixes in 1 projects; 43 projects unchanged)
demisto/content (+1 -1 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview
+ Packs/ThreatQ/Integrations/ThreatQ/ThreatQ.py:106:12: E999 SyntaxError: Multiple exception types must be parenthesized - Packs/ThreatQ/Integrations/ThreatQ/ThreatQ.py:106:21: E999 SyntaxError: Unexpected token ,
Changes by rule (1 rules affected)
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| E999 | 2 | 1 | 1 | 0 | 0 |
Formatter (stable)
✅ ecosystem check detected no format changes.
Formatter (preview)
✅ ecosystem check detected no format changes.
Member
Author
|
The ecosystem changes are as expected, updating the syntax error message. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.