Skip to content

Consider exactly _ for wildcard pattern#10896

Merged
dhruvmanila merged 1 commit intodhruv/parserfrom
dhruv/as-pattern
Apr 12, 2024
Merged

Consider exactly _ for wildcard pattern#10896
dhruvmanila merged 1 commit intodhruv/parserfrom
dhruv/as-pattern

Conversation

@dhruvmanila
Copy link
Copy Markdown
Member

No description provided.

@dhruvmanila dhruvmanila added bug Something isn't working parser Related to the parser fuzzer Surfaced via fuzzing. labels Apr 12, 2024
@dhruvmanila dhruvmanila merged commit 4063359 into dhruv/parser Apr 12, 2024
@dhruvmanila dhruvmanila deleted the dhruv/as-pattern branch April 12, 2024 06:03
dhruvmanila added a commit that referenced this pull request Apr 15, 2024
dhruvmanila added a commit that referenced this pull request Apr 16, 2024
dhruvmanila added a commit that referenced this pull request Apr 16, 2024
dhruvmanila added a commit that referenced this pull request Apr 17, 2024
dhruvmanila added a commit that referenced this pull request Apr 18, 2024
dhruvmanila added a commit that referenced this pull request Apr 18, 2024
(Supersedes #9152, authored by @LaBatata101)

## Summary

This PR replaces the current parser generated from LALRPOP to a
hand-written recursive descent parser.

It also updates the grammar for [PEP
646](https://peps.python.org/pep-0646/) so that the parser outputs the
correct AST. For example, in `data[*x]`, the index expression is now a
tuple with a single starred expression instead of just a starred
expression.

Beyond the performance improvements, the parser is also error resilient
and can provide better error messages. The behavior as seen by any
downstream tools isn't changed. That is, the linter and formatter can
still assume that the parser will _stop_ at the first syntax error. This
will be updated in the following months.

For more details about the change here, refer to the PR corresponding to
the individual commits and the release blog post.

## Test Plan

Write _lots_ and _lots_ of tests for both valid and invalid syntax and
verify the output.

## Acknowledgements

- @MichaReiser for reviewing 100+ parser PRs and continuously providing
guidance throughout the project
- @LaBatata101 for initiating the transition to a hand-written parser in
#9152
- @addisoncrump for implementing the fuzzer which helped
[catch](#10903)
[a](#10910)
[lot](#10966)
[of](#10896)
[bugs](#10877)

---------

Co-authored-by: Victor Hugo Gomes <labatata101@linuxmail.org>
Co-authored-by: Micha Reiser <micha@reiser.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working fuzzer Surfaced via fuzzing. parser Related to the parser

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant