Struct not tuple for compiled per-file ignores#10864
Conversation
|
Co-authored-by: Alex Waygood <alex.waygood@gmail.com>
|
@MichaReiser @snowsignal requesting another review because I would like to make sure that the change we made to The previous But anyway, the new version here is much better / more readable (for Display purposes), it just shows the actual file pattern of the |
snowsignal
left a comment
There was a problem hiding this comment.
Looks good to me! Thank you 😁
## Summary Code cleanup for per-file ignores; use a struct instead of a tuple. Named the structs for individual ignores and the list of ignores `CompiledPerFileIgnore` and `CompiledPerFileIgnoreList`. Name choice is because we already have a `PerFileIgnore` struct for a pre-compiled-matchers form of the config. Name bikeshedding welcome. ## Test Plan Refactor, should not change behavior; existing tests pass. --------- Co-authored-by: Alex Waygood <alex.waygood@gmail.com>
Summary
Code cleanup for per-file ignores; use a struct instead of a tuple.
Named the structs for individual ignores and the list of ignores
CompiledPerFileIgnoreandCompiledPerFileIgnoreList. Name choice is because we already have aPerFileIgnorestruct for a pre-compiled-matchers form of the config. Name bikeshedding welcome.Test Plan
Refactor, should not change behavior; existing tests pass.