Respect # noqa directives on __all__ openers#10798
Merged
charliermarsh merged 1 commit intomainfrom Apr 6, 2024
Merged
Conversation
a3d7a63 to
b20be48
Compare
Contributor
|
AlexWaygood
approved these changes
Apr 6, 2024
Member
AlexWaygood
left a comment
There was a problem hiding this comment.
Nice, thanks for the fix!
AlexWaygood
reviewed
Apr 6, 2024
b20be48 to
edf1a26
Compare
Glyphack
pushed a commit
to Glyphack/ruff
that referenced
this pull request
Apr 12, 2024
## Summary
Historically, given:
```python
__all__ = [ # noqa: F822
"Bernoulli",
"Beta",
"Binomial",
]
```
The F822 violations would be attached to the `__all__`, so this `# noqa`
would be enforced for _all_ definitions in the list. This changed in
astral-sh#10525 for the better, in that we
now use the range of each string. But these `# noqa` directives stopped
working.
This PR sets the `__all__` as a parent range in the diagnostic, so that
these directives are respected once again.
Closes astral-sh#10795.
## Test Plan
`cargo test`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Historically, given:
The F822 violations would be attached to the
__all__, so this# noqawould be enforced for all definitions in the list. This changed in #10525 for the better, in that we now use the range of each string. But these# noqadirectives stopped working.This PR sets the
__all__as a parent range in the diagnostic, so that these directives are respected once again.Closes #10795.
Test Plan
cargo test