Track conditional deletions in the semantic model#10415
Merged
charliermarsh merged 1 commit intomainfrom Mar 15, 2024
Merged
Conversation
2ade3d9 to
1e4d01d
Compare
Contributor
|
dylwil3
added a commit
that referenced
this pull request
Mar 21, 2026
… variables (#24088) We already skip `F821` for things like this: ```python x = 1 if cond: del x print(x) # no diagnostic here ``` But when we checked for "conditional branches" we were only looking for `match`, `if`, and `while` statements. Here we also check for except handlers and `else` clauses. We continue to regard `try` statements as "unconditionally executing" even though that's not quite true. Closes #6242 As an aside: I originally wanted to use the `BindingKind` variant `ConditionalDeletion` introduced way back in #10415, but it turns out we never actually constructed an instance of it! We could, if we ever needed to track the "thing that was conditionally deleted". But since that doesn't seem to have ever arisen in practice, I just got rid of the variant and its references altogether.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Given
del X, we'll typically add aBindingKind::DeletiontoXto shadow the current binding. However, if the deletion is inside of a conditional operation, we won't, as in:We will, however, track it as a reference to the binding. This PR adds the expression context to those resolved references, so that we can detect that the
Xinglobal Xwas "assigned to".Closes #10397.