F821: Fix false negatives in .py files when from __future__ import annotations is active#10362
Merged
AlexWaygood merged 1 commit intoastral-sh:mainfrom Mar 12, 2024
Merged
Conversation
…t annotations` is active
.pyi files when from __future__ import annotations is active.py files when from __future__ import annotations is active
Member
Author
|
(Original title of the PR said " |
Contributor
|
zanieb
approved these changes
Mar 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #10340.
Currently, ruff emits no F821 rules on the following
.pyfile, but the lines marked with XXX all fail at runtime due to undefined names, despitefrom __future__ import annotationsbeing active:This PR fixes that.
Much like #10341, it took me an annoying amount of time to figure out how to fix this, but it turned out to be hilariously easy to fix once I saw where to make the change 🙃
Test Plan
cargo test