Skip to content

Respect external codes in file-level exemptions#10203

Merged
charliermarsh merged 1 commit intomainfrom
charlie/ext
Mar 3, 2024
Merged

Respect external codes in file-level exemptions#10203
charliermarsh merged 1 commit intomainfrom
charlie/ext

Conversation

@charliermarsh
Copy link
Member

@charliermarsh charliermarsh commented Mar 3, 2024

We shouldn't warn when an "external" code is used in a file-level exemption.

Closes #10202.

@charliermarsh charliermarsh added bug Something isn't working suppression Related to supression of violations e.g. noqa labels Mar 3, 2024
@charliermarsh charliermarsh enabled auto-merge (squash) March 3, 2024 00:07
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 3, 2024

CodSpeed Performance Report

Merging #10203 will improve performances by 5.33%

Comparing charlie/ext (1f652b7) with main (39a3031)

Summary

⚡ 2 improvements
✅ 28 untouched benchmarks

Benchmarks breakdown

Benchmark main charlie/ext Change
linter/default-rules[large/dataset.py] 20.1 ms 19.1 ms +5.33%
linter/default-rules[unicode/pypinyin.py] 1.6 ms 1.5 ms +4.7%

@charliermarsh charliermarsh merged commit 7515196 into main Mar 3, 2024
@charliermarsh charliermarsh deleted the charlie/ext branch March 3, 2024 00:20
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

nkxxll pushed a commit to nkxxll/ruff that referenced this pull request Mar 10, 2024
We shouldn't warn when an "external" code is used in a file-level
exemption.

Closes astral-sh#10202.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working suppression Related to supression of violations e.g. noqa

Projects

None yet

Development

Successfully merging this pull request may close these issues.

# flake8: noqa top-of-the-file comment doesn't respect external config

1 participant