Skip to content

enable frame pointers for linux x86-64 and aarch64#997

Merged
jjhelmus merged 1 commit intoastral-sh:mainfrom
jjhelmus:add_frame_pointers
Mar 18, 2026
Merged

enable frame pointers for linux x86-64 and aarch64#997
jjhelmus merged 1 commit intoastral-sh:mainfrom
jjhelmus:add_frame_pointers

Conversation

@jjhelmus
Copy link
Copy Markdown
Contributor

@jjhelmus jjhelmus commented Mar 4, 2026 •
edited
Loading

Enable frame pointers on x86-64 and aarch64 Linux platforms.

closes #992

@jjhelmus jjhelmus added the platform:linux Specific to the Linux platform label Mar 4, 2026
@jjhelmus jjhelmus force-pushed the add_frame_pointers branch from c1c44b9 to 877018d Compare March 4, 2026 16:43
@jjhelmus
Copy link
Copy Markdown
Contributor Author

jjhelmus commented Mar 6, 2026

The native 3.12 build on linux segfaults

2026-03-04T18:01:02.9713076Z cpython-3.12> /build/build-cpython.sh: line 889: 11960 Segmentation fault (core dumped) ${BUILD_PYTHON} "${PIP_WHEEL}/pip" install --prefix="${ROOT}/out/python/install" --no-cache-dir --no-index "${PIP_WHEEL}"

Strange

@jjhelmus jjhelmus mentioned this pull request Mar 13, 2026
Merged
@jjhelmus
enable frame pointers for linux x86-64 and aarch64
c792d72 
Enable frame pointers on x86-64 and aarch64 Linux platforms.
@jjhelmus jjhelmus force-pushed the add_frame_pointers branch from 877018d to c792d72 Compare March 13, 2026 22:26
@jjhelmus jjhelmus marked this pull request as ready for review March 16, 2026 14:58
@jjhelmus
Copy link
Copy Markdown
Contributor Author

jjhelmus commented Mar 16, 2026

I'm comparing the performance building with frame-pointers vs without to get an idea of how much overhead they introduce. Should have full results later today or tomorrow.

@jjhelmus jjhelmus mentioned this pull request Mar 16, 2026
Closed
@jjhelmus jjhelmus requested a review from geofft March 16, 2026 23:22
@jjhelmus
Copy link
Copy Markdown
Contributor Author

jjhelmus commented Mar 18, 2026

Results from running the pyperformance benchmark suite on builds with and without frame-pointer on a Linux x86-64 host:

Python Version w-FP geometric mean
3.10 1.02x slower
3.11 1.02x slower
3.12 1.02x slower
3.13 1.02x faster
3.14 1.03x slower

Yes, adding frame-pointer improved the performance of 3.13. I don't understand precisely but re-running the benchmarks replicated the results.

Overall a 2-3% performance loss from adding frame-pointers is a reasonable trade-off for the improvement in observability.

@jjhelmus jjhelmus merged commit cac6f9f into astral-sh:main Mar 18, 2026
888 of 889 checks passed
@jjhelmus jjhelmus mentioned this pull request Mar 19, 2026
Closed
Schamper pushed a commit to fox-it/python-build-pystandalone that referenced this pull request Mar 24, 2026
@jjhelmus @Schamper
enable frame pointers for linux x86-64 and aarch64 (astral-sh#997)
f0b298f 
Enable frame pointers on x86-64 and aarch64 Linux platforms.

closes astral-sh#992
Schamper pushed a commit to fox-it/python-build-pystandalone that referenced this pull request Mar 24, 2026
@jjhelmus @Schamper
enable frame pointers for linux x86-64 and aarch64 (astral-sh#997)
ca336e1 
Enable frame pointers on x86-64 and aarch64 Linux platforms.

closes astral-sh#992
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zanieb zanieb zanieb approved these changes

@geofft geofft Awaiting requested review from geofft

Assignees

No one assigned

Labels

platform:linux Specific to the Linux platform

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enable frame pointers on Linux for the perf profiler

2 participants

@jjhelmus @zanieb