Conversation
9c5748b to
62883a6
Compare
LLVM 19 yields a compile error without these patches. Strictly speaking we may only need the final one. However there are conflicts unless we take all patches to `src/aarch64/sysv.S`. So we just take the 3 of them.
62883a6 to
2b08be0
Compare
Collaborator
Author
|
This looks to be passing CI. So asking for review. |
charliermarsh
approved these changes
Dec 16, 2024
Member
|
It looks like two builds failed here -- possible that those are new failures? |
Member
|
(Only asking because they're also failing on main and on my own PRs now :)) |
Collaborator
Author
|
Uh what. I merged on my phone and I only saw green. Feel free to revert I guess. |
Collaborator
Author
|
I reproduced the failure locally and reverted. This looks like upstream issue python/cpython#124948. I was going to say it was strange it only reproduced on 3.12. But we currently only have BOLT enabled on 3.12. So looks like a general BOLT regression on LLVM 19.1.0. |
Collaborator
Author
|
Well, not the same symbol as the upstream CPython issue. But same failure mode of unable to locate an address. My best guess is BOLT isn't able to follow a rewrite performed by PGO or itself. |
Merged
zanieb
pushed a commit
that referenced
this pull request
Jan 2, 2025
This is a redo of #420, which was merged prematurely. With the BOLT changes from #463 merged, LLVM 19 _just works_. As part of this we also modernize the BOLT apply settings to follow the recommendations at https://llvm.org/devmtg/2024-03/slides/practical-use-of-bolt.pdf. This includes enabling support for loading hot code from a huge page at runtime. This should _just work_ and could result in perf wins via improved iTLB hit rate, etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.