Remove shared- prefix from Windows profiles#241
Closed
charliermarsh wants to merge 4 commits into
Closed
Conversation
charliermarsh
commented
Mar 30, 2024
charliermarsh
commented
Mar 30, 2024
| # uplink.c tries to find the OPENSSL_Applink function exported from the current | ||
| # executable. However, it is exported from _ssl[_d].pyd in shared builds. So | ||
| # update its sounce to look for it from there. | ||
| if "shared" in profile: |
Member
Author
There was a problem hiding this comment.
(Always true. Should've been removed in the preceding PR.)
Collaborator
|
I manually cancelled actions for Linux and macOS due to xz download bustage. Rebase on |
8802044 to
eee528f
Compare
bedfdc4 to
2f59b94
Compare
indygreg
approved these changes
Apr 1, 2024
indygreg
left a comment
Collaborator
There was a problem hiding this comment.
This looks like it should work! Thanks for following up!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In #234, we removed the Windows static builds from python-build-standalone. As such, the
shared-prefix (in, e.g.,shared-pgo) is no longer necessary, since there's no need to differentiate the shared builds from the static builds.This PR removes the
shared-prefix, but continues to publish under both profiles to allow for a transition period for consumers of theshared-builds.Closes #237.
Test Plan
Downloaded one of the release artifacts locally: